On 03/28/2018 05:12 PM, Alexander Korotkov wrote: > On Wed, Mar 28, 2018 at 4:44 PM, Tomas Vondra > <tomas.von...@2ndquadrant.com <mailto:tomas.von...@2ndquadrant.com>> wrote: > > On 03/28/2018 03:28 PM, Teodor Sigaev wrote: > >> BTW, patch had conflicts with master. Please, find rebased version > >> attached. > > > > Despite by patch conflist patch looks commitable, has anybody objections > > to commit it? > > > > Patch recieved several rounds of review during 2 years, and seems to me, > > keeping it out from sources may cause a lost it. Although it suggests > > performance improvement in rather wide usecases. > > > > No objections from me - if you want me to do one final round of review > after the rebase (not sure how invasive it'll turn out), let me know. > > > Rebased patch is attached. Incremental sort get used in multiple places > of partition_aggregate regression test. I've checked those cases, and > it seems that incremental sort was selected right. >
OK, I'll take a look. > BTW one detail I'd change is name of the GUC variable. enable_incsort > seems unnecessarily terse - let's go for enable_incremental_sort or > something like that. > > > Already enable_incsort was already renamed to enable_incrementalsort > since [1]. > > 1. > https://www.postgresql.org/message-id/CAPpHfduAVmiGDZC%2BdfNL1rEGu0mt45Rd_mxwjY57uqwWhrvQzg%40mail.gmail.com > > Ah, apologies. I've been looking at the wrong version. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services