On Wed, Nov 24, 2021 at 3:37 AM vignesh C <vignes...@gmail.com> wrote: > > On Tue, Nov 23, 2021 at 4:58 PM Ajin Cherian <itsa...@gmail.com> wrote: > > > > Attaching a new patchset v41 which includes changes by both Peter and > > myself. > > Few comments on v41-0002 patch: ... > 2) Tab completion completes with "WHERE (" in case of "alter > publication pub1 add table t1,": > + /* ALTER PUBLICATION <name> SET TABLE <name> */ > + /* ALTER PUBLICATION <name> ADD TABLE <name> */ > + else if (Matches("ALTER", "PUBLICATION", MatchAny, "SET|ADD", > "TABLE", MatchAny)) > + COMPLETE_WITH("WHERE ("); > > Should this be changed to: > + /* ALTER PUBLICATION <name> SET TABLE <name> */ > + /* ALTER PUBLICATION <name> ADD TABLE <name> */ > + else if (Matches("ALTER", "PUBLICATION", MatchAny, "SET|ADD", > "TABLE", MatchAny) && (!ends_with(prev_wd, ',')) > + COMPLETE_WITH("WHERE ("); >
Fixed in v44 [1] ------ [1] https://www.postgresql.org/message-id/CAHut%2BPtjxzedJPbSZyb9pd72%2BUrGEj6HagQQbCdO0YJvr7OyJg%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia