On Wed, Dec 8, 2021 at 2:50 AM Bossart, Nathan <bossa...@amazon.com> wrote:
>
> On 12/7/21, 12:10 AM, "Bharath Rupireddy"
> <bharath.rupireddyforpostg...@gmail.com> wrote:
> > Here's a patch that I've come up with. Please see if this looks okay
> > and let me know if we want to take it forward so that I can add a CF
> > entry.
>
> Overall, the patch seems reasonable to me.
Thanks for reviewing this.
> + case DB_IN_END_OF_RECOVERY_CHECKPOINT:
> + ereport(LOG,
> + (errmsg("database system was
> interrupted while in end-of-recovery checkpoint at %s",
> +
> str_time(ControlFile->time))));
> + break;
>
> I noticed that some (but not all) of the surrounding messages say
> "last known up at" the control file time. I'm curious why you chose
> not to use that phrasing in this case.
If state is DB_IN_END_OF_RECOVERY_CHECKPOINT that means the db was
interrupted while in end-of-recovery checkpoint, so I used the
phrasing similar to DB_IN_CRASH_RECOVERY and DB_IN_ARCHIVE_RECOVERY
cases. I would like to keep it as-is (in the v1 patch) unless anyone
has other thoughts here?
(errmsg("database system was interrupted while in recovery at %s",
(errmsg("database system was interrupted while in recovery at log time %s",
I added a CF entry here - https://commitfest.postgresql.org/36/3442/
Regards,
Bharath Rupireddy.
