On 12/13/21 09:26, Tomas Vondra wrote: > On 12/13/21 14:38, Dag Lem wrote: >> Please find attached an updated patch, with the following fixes: >> >> * Replaced remaining malloc/free with palloc/pfree. >> * Made "make check" pass. >> * Updated notes on other implementations. >> > > Thanks, looks interesting. A couple generic comments, based on a quick > code review. > > 1) Can the extension be marked as trusted, just like fuzzystrmatch? > > 2) The docs really need an explanation of what the extension is for, > not just a link to fuzzystrmatch. Also, a couple examples would be > helpful, I guess - similarly to fuzzystrmatch. The last line in the > docs is annoyingly long.
It's not clear to me why we need a new module for this. Wouldn't it be better just to add the new function to fuzzystrmatch? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
