On Fri, Dec 17, 2021 at 7:12 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Fri, Dec 17, 2021 at 3:23 PM Peter Eisentraut > <peter.eisentr...@enterprisedb.com> wrote: > > > > On 13.12.21 04:12, Greg Nancarrow wrote: > > > (ii) "Setting -1 means to reset the transaction ID" > > > > > > Shouldn't it be explained what resetting actually does and when it can > > > be, or is needed to be, done? Isn't it automatically reset? > > > I notice that negative values (other than -1) seem to be regarded as > > > valid - is that right? > > > Also, what happens if this option is set multiple times? Does it just > > > override and use the latest setting? (other option handling errors out > > > with errorConflictingDefElem()). > > > e.g. alter subscription sub skip (xid = 721, xid = 722); > > > > Let's not use magic numbers and instead use a syntax that is more > > explicit, like SKIP (xid = NONE) or RESET SKIP or something like that. > > > > +1 for using SKIP (xid = NONE) because otherwise first we need to > introduce RESET syntax for this command.
Agreed. Thank you for the comment! Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/