Op 19-12-2021 om 07:23 schreef Pavel Stehule:
I am sending new versions of patches.
I hope I solved all Tomas's objections.
1. The schema variables were renamed to session variables
2. I fixed issues related to creating, dropping variables under
subtransactions + regress tests
3. I fixed issues in pg_dump + regress tests
> [0001-schema-variables-20211219.patch]
> [0002-schema-variables-20211219.patch]
Hi Pavel,
I get an error during test 'session_variables'.
(on the upside, my own little testsuite runs without error)
thanks,
Erik Rijkers
diff -U3
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/expected/session_variables.out
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/results/session_variables.out
---
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/expected/session_variables.out
2021-12-19 07:48:40.422821574 +0100
+++
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/results/session_variables.out
2021-12-19 08:00:29.286820957 +0100
@@ -32,11 +32,11 @@
SET ROLE TO DEFAULT;
-- check output
\dV+ var1
- List of variables
- Schema | Name | Type | Is nullable | Is mutable | Default | Owner |
Transactional end action | Access privileges | Description
-----------+------+---------+-------------+------------+---------+-------+--------------------------+------------------------+-------------
- svartest | var1 | numeric | t | t | | pavel |
| pavel=SW/pavel +|
- | | | | | | |
| var_test_role=SW/pavel |
+ List of
variables
+ Schema | Name | Type | Is nullable | Is mutable | Default | Owner |
Transactional end action | Access privileges | Description
+----------+------+---------+-------------+------------+---------+----------+--------------------------+---------------------------+-------------
+ svartest | var1 | numeric | t | t | | aardvark |
| aardvark=SW/aardvark +|
+ | | | | | | |
| var_test_role=SW/aardvark |
(1 row)
REVOKE ALL ON VARIABLE var1 FROM var_test_role;
@@ -745,10 +745,10 @@
CREATE VARIABLE var1 AS int DEFAULT 100;
COMMENT ON VARIABLE var1 IS 'some variable comment';
\dV+ var1
- List of
variables
- Schema | Name | Type | Is nullable | Is mutable | Default | Owner |
Transactional end action | Access privileges | Description
-----------+------+---------+-------------+------------+---------+-------+--------------------------+-------------------+-----------------------
- svartest | var1 | integer | t | t | 100 | pavel |
| | some variable comment
+ List of
variables
+ Schema | Name | Type | Is nullable | Is mutable | Default | Owner |
Transactional end action | Access privileges | Description
+----------+------+---------+-------------+------------+---------+----------+--------------------------+-------------------+-----------------------
+ svartest | var1 | integer | t | t | 100 | aardvark |
| | some variable comment
(1 row)
DROP VARIABLE var1;
