On 30 March 2018 at 02:55, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > On 03/29/2018 03:09 PM, David Rowley wrote: >> I meant to mention earlier that I coded >> agg_args_have_sendreceive_funcs() to only check for send/receive >> functions. Really we could allow a byval types without send/receive >> functions, since the serial/deserial just send the raw datums in that >> case, but then the function becomes >> agg_byref_args_have_sendreceive_funcs(), which seemed a bit obscure, >> so I didn't do that. Maybe I should? > > I'd do that. Not sure the function name needs to change, but perhaps > agg_args_support_sendreceive() would be better - it covers both byref > types (which require send/receive functions) and byval (which don't).
The attached patch implements this. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
combinefn_for_string_and_array_aggs_v10.patch
Description: Binary data
