On 23.12.21 12:40, Fabien COELHO wrote:
This is also a feature/bug of libpq which happens to be hidden by
PQexec: when one command crashes PQgetResult actually returns *2*
results. First one with the FATAL message, second one when libpq figures
out that the connection was lost with the second message appended to the
first. PQexec just happen to silently ignore the first result. I added a
manual reset of the error message when first shown so that it is not
shown twice. It is unclear to me whether the reset should be somewhere
in libpq instead. I added a voluntary crash at the end of the psql test.
With this "voluntary crash", the regression test output is now
psql ... ok (test process exited with
exit code 2) 281 ms
Normally, I'd expect this during development if there was a crash
somewhere, but showing this during a normal run now, and moreover still
saying "ok", is quite weird and confusing. Maybe this type of test
should be done in the TAP framework instead.
