On Sun, Apr 1, 2018 at 6:01 PM, Julian Markwort < julian.markw...@uni-muenster.de> wrote:
> On 1. of April 2018 17:46:38 MESZ wrote Magnus Hagander < > mag...@hagander.net>: > > >I assume this is a patch that's intended to be applied on top of the > >previous patch? If so, please submit the complete pach to make sure the > >correct combination ends up actually being reviewed. > > The v02.patch attached to my last mail contains both source and > documentation changes. > Hmm. I think I may have been looking at the wrong file. Sorry! >Keeping patches as short as possible is not a good thing itself. The > >important part is that the resulting code and documentation is the best > >possible. Sometimes you might want to turn it into two patches > >submitted at > >the same time if one is clearly just reorganisation, but avoiding code > >restructure just to keep the lines of patch down is not helpful. > > I think I've made the right compromises regarding readability of the > documentation in my patch then. > > A happy Easter, passover, or Sunday to you > You, too! (I shall return to reviewing it after the holidays are over) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
