On Thu, Jan 20, 2022 at 12:01:29PM +0900, Michael Paquier wrote: > On Wed, Jan 19, 2022 at 06:05:40PM -0600, Justin Pryzby wrote: > > > I'm not sure these restrictions are needed ? > > This could lead to issues with rmtree() if we are not careful enough, > no? We'd had our deal of argument injections with pg_upgrade commands > in the past (fcd15f1).
We require that the dir not exist, by testing if (mkdir()). So it's okay if someone specifies ../whatever or $CWD. -- Justin