Hi, Thank you for committing a great feature. I have tested the committed features. The attached small patch fixes the output of the --help message. In the previous commit, only gzip and none were output, but in the attached patch, client-gzip and server-gzip are added.
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Robert Haas <robertmh...@gmail.com>
Sent: Saturday, January 22, 2022 3:33 AM
To: Dipesh Pandit <dipesh.pan...@gmail.com>; Michael Paquier
<mich...@paquier.xyz>
Cc: Jeevan Ladhe <jeevan.la...@enterprisedb.com>; tushar
<tushar.ah...@enterprisedb.com>; Dmitry Dolgov <9erthali...@gmail.com>; Mark
Dilger <mark.dil...@enterprisedb.com>; pgsql-hack...@postgresql.org
Subject: Re: refactoring basebackup.c
On Wed, Jan 19, 2022 at 4:26 PM Robert Haas <robertmh...@gmail.com> wrote:
> I spent some time thinking about test coverage for the server-side
> backup code today and came up with the attached (v12-0003).
I committed the base backup target patch yesterday, and today I updated the
remaining code in light of Michael Paquier's commit
5c649fe153367cdab278738ee4aebbfd158e0546. Here is the resulting patch.
Michael, I am proposing to that we remove this message as part of this commit:
- pg_log_info("no value specified for compression
level, switching to default");
I think most people won't want to specify a compression level, so emitting a
message when they don't seems too verbose.
--
Robert Haas
EDB: http://www.enterprisedb.com
pg_basebackup_option_v1.diff
Description: pg_basebackup_option_v1.diff
