On Tue, Jan 25, 2022 at 8:15 PM Michael Paquier <mich...@paquier.xyz> wrote: > Sure, but I don't think that it is a good idea to unify that yet, at > least not until pg_dump is able to handle LZ4 as an option, as the > main benefit that we'd gain here is to be able to change the code to a > switch/case without defaults where we would detect code paths that > require a refresh once adding support for a new option.
I think those places could just throw a "lz4 compression is not supported" elog() and then you could just grep for everyplace where that string appears. But I am not of a mind to fight about it. I was just pointing out the duplication. -- Robert Haas EDB: http://www.enterprisedb.com
