On Sun, Jan 30, 2022 at 1:07 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2022-Jan-29, Bharath Rupireddy wrote: > > > Removing the xloginsert.h in xlog.h would need us to add xloginsert.h > > in more areas. > > Sure. > > > And also, it might break any non-core extensions that > > includes just xlog.h and gets xloginsert.h. > > That's a pretty easy fix anyway -- it's not even version-specific, since > the fix would work with the older versions. It's not something that > would break on a minor version, either.
Here's the v3 patch removing xloginsert.h from xlog.h and adding xloginsert.h in the required files. Regards, Bharath Rupireddy.
From f09891ded020517539db0f691923538608d220ab Mon Sep 17 00:00:00 2001 From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Date: Sun, 30 Jan 2022 12:59:21 +0000 Subject: [PATCH v3] remove xloginsert.h from xlog.h --- src/backend/access/hash/hash.c | 1 + src/backend/access/hash/hashinsert.c | 1 + src/backend/access/hash/hashovfl.c | 1 + src/backend/access/hash/hashpage.c | 1 + src/backend/access/heap/pruneheap.c | 1 + src/backend/access/heap/vacuumlazy.c | 1 + src/backend/access/nbtree/nbtdedup.c | 1 + src/backend/access/transam/commit_ts.c | 1 + src/backend/commands/tablecmds.c | 1 + src/backend/replication/logical/origin.c | 1 + src/backend/storage/buffer/bufmgr.c | 1 + src/include/access/xlog.h | 1 - 12 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/backend/access/hash/hash.c b/src/backend/access/hash/hash.c index d48c8a4549..a259a301fa 100644 --- a/src/backend/access/hash/hash.c +++ b/src/backend/access/hash/hash.c @@ -22,6 +22,7 @@ #include "access/hash_xlog.h" #include "access/relscan.h" #include "access/tableam.h" +#include "access/xloginsert.h" #include "catalog/index.h" #include "commands/progress.h" #include "commands/vacuum.h" diff --git a/src/backend/access/hash/hashinsert.c b/src/backend/access/hash/hashinsert.c index 2dfa0ec35e..faf609c157 100644 --- a/src/backend/access/hash/hashinsert.c +++ b/src/backend/access/hash/hashinsert.c @@ -17,6 +17,7 @@ #include "access/hash.h" #include "access/hash_xlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "storage/buf_internals.h" #include "storage/lwlock.h" diff --git a/src/backend/access/hash/hashovfl.c b/src/backend/access/hash/hashovfl.c index c9449b74d8..4836875196 100644 --- a/src/backend/access/hash/hashovfl.c +++ b/src/backend/access/hash/hashovfl.c @@ -19,6 +19,7 @@ #include "access/hash.h" #include "access/hash_xlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "utils/rel.h" diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index ee351aea09..28c5297a1d 100644 --- a/src/backend/access/hash/hashpage.c +++ b/src/backend/access/hash/hashpage.c @@ -30,6 +30,7 @@ #include "access/hash.h" #include "access/hash_xlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "port/pg_bitutils.h" #include "storage/lmgr.h" diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c index b3e2eec52f..b6500763a5 100644 --- a/src/backend/access/heap/pruneheap.c +++ b/src/backend/access/heap/pruneheap.c @@ -19,6 +19,7 @@ #include "access/htup_details.h" #include "access/transam.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "miscadmin.h" #include "pgstat.h" diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index 1c2f30b686..f09ad8f271 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -44,6 +44,7 @@ #include "access/visibilitymap.h" #include "access/xact.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/index.h" #include "catalog/storage.h" #include "commands/dbcommands.h" diff --git a/src/backend/access/nbtree/nbtdedup.c b/src/backend/access/nbtree/nbtdedup.c index 1547e73049..4c48554aec 100644 --- a/src/backend/access/nbtree/nbtdedup.c +++ b/src/backend/access/nbtree/nbtdedup.c @@ -16,6 +16,7 @@ #include "access/nbtree.h" #include "access/nbtxlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "utils/rel.h" diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c index 9419a5ca41..20950eb1e4 100644 --- a/src/backend/access/transam/commit_ts.c +++ b/src/backend/access/transam/commit_ts.c @@ -28,6 +28,7 @@ #include "access/htup_details.h" #include "access/slru.h" #include "access/transam.h" +#include "access/xloginsert.h" #include "access/xlogutils.h" #include "catalog/pg_type.h" #include "funcapi.h" diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 1f0654c2f5..3e83f375b5 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -26,6 +26,7 @@ #include "access/toast_compression.h" #include "access/xact.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "catalog/heap.h" #include "catalog/index.h" diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c index eb040152f9..e91fa93d03 100644 --- a/src/backend/replication/logical/origin.c +++ b/src/backend/replication/logical/origin.c @@ -74,6 +74,7 @@ #include "access/htup_details.h" #include "access/table.h" #include "access/xact.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "catalog/indexing.h" #include "funcapi.h" diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index a2512e750c..f5459c68f8 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -34,6 +34,7 @@ #include <unistd.h> #include "access/tableam.h" +#include "access/xloginsert.h" #include "access/xlogutils.h" #include "catalog/catalog.h" #include "catalog/storage.h" diff --git a/src/include/access/xlog.h b/src/include/access/xlog.h index bb0c52686a..5f934dd65a 100644 --- a/src/include/access/xlog.h +++ b/src/include/access/xlog.h @@ -13,7 +13,6 @@ #include "access/rmgr.h" #include "access/xlogdefs.h" -#include "access/xloginsert.h" #include "access/xlogreader.h" #include "datatype/timestamp.h" #include "lib/stringinfo.h" -- 2.25.1
