On Fri, Oct 30, 2020 at 9:46 PM Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > > On Fri, Oct 16, 2020 at 03:35:51PM -0700, Peter Geoghegan wrote:
> >I suppose that a change like this could end up affecting other things, > >such as EXPLAIN ANALYZE statistics. OTOH we only break out index pages > >separately for bitmap scans at the moment, so maybe it could be fairly > >well targeted. And, maybe this is unappealing given the current > >statistics collector limitations. I'm not volunteering to work on it > >right now, but it would be nice to fix this. Please don't wait for me > >to do it. > > > > It seems to me this should not be a particularly difficult patch in > principle, so suitable for new contributors. The main challenge would be > passing information about what page we're dealing with (internal/leaf) > to the place actually calling pgstat_count_buffer_(read|hit). That > happens in ReadBufferExtended, which just has no idea what page it's > dealing with. Not sure how to do that cleanly ... Is this a TODO candidate? What would be a succinct title for it? -- John Naylor EDB: http://www.enterprisedb.com
