On Tue, Feb 08, 2022 at 10:44:07AM +0900, Michael Paquier wrote: > What do you think about the updated version attached? I have applied > the addition of config_data() separately.
Looks fine > + # Check if this line matches a GUC parameter. > + if ($line =~ m/^#?([_[:alpha:]]+) (= .*|[^ ]*$)/) I think this is the regex I wrote to handle either "name = value" or "name value", which was needed between f47ed79cc..4d7c3e344. See skip_equals. It's fine the way it is, but could also remove the 2nd half of the alternation (|), since GUCs shouldn't be added to sample.conf without '='. -- Justin
