Hi, Hackers.
Thank you for developing a great feature.
The current help message shown below does not seem to be able to specify the
'client-' or 'server-' for lz4 compression.
--compress = {[{client, server}-]gzip, lz4, none}[:LEVEL]
The attached small patch fixes the help message as follows:
--compress = {[{client, server}-]{gzip, lz4}, none}[:LEVEL]
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Robert Haas <robertmh...@gmail.com>
Sent: Saturday, February 12, 2022 12:50 AM
To: Justin Pryzby <pry...@telsasoft.com>
Cc: Jeevan Ladhe <jeevanladhe...@gmail.com>; Dipesh Pandit
<dipesh.pan...@gmail.com>; Abhijit Menon-Sen <a...@toroid.org>; Dmitry Dolgov
<9erthali...@gmail.com>; Jeevan Ladhe <jeevan.la...@enterprisedb.com>; Mark
Dilger <mark.dil...@enterprisedb.com>; pgsql-hack...@postgresql.org; tushar
<tushar.ah...@enterprisedb.com>
Subject: Re: refactoring basebackup.c
On Fri, Feb 11, 2022 at 10:29 AM Justin Pryzby <pry...@telsasoft.com> wrote:
> FYI: there's a couple typos in the last 2 patches.
Hmm. OK. But I don't consider "can be optionally specified" incorrect or worse
than "can optionally be specified".
I do agree that spelling words correctly is a good idea.
--
Robert Haas
EDB: http://www.enterprisedb.com
pg_basebackup_help_v1.diff
Description: pg_basebackup_help_v1.diff
