Hi,

On 2022-02-12 15:12:21 -0600, Justin Pryzby wrote:
> I think they would've been visible in the CI environment, too.

Yea, but only if you looked carefully enough. The postgres github repo has CI
enabled, and it's green. But the windows build step does show the warnings:

https://cirrus-ci.com/task/6185407539838976?logs=build#L2066
https://cirrus-ci.com/github/postgres/postgres/

[19:08:09.086] c:\cirrus\src\backend\replication\basebackup_lz4.c(87): warning 
C4715: 'bbsink_lz4_new': not all control paths return a value 
[c:\cirrus\postgres.vcxproj]

Probably worth scripting something to make the windows task error out if there
had been warnings, but only after running the tests.

Greetings,

Andres Freund


Reply via email to