Robert Haas <robertmh...@gmail.com> writes:
> On Mon, Feb 14, 2022 at 1:19 AM Tom Lane <t...@sss.pgh.pa.us> wrote:
>> For a very long time, the AIX 7.1 buildfarm members (sungazer and tern)
>> have complained about
>> ip.c:236:17: warning: conversion from 'long unsigned int' to 'uchar_t' {aka
>> 'unsigned char'} changes value from '1025' to '1' [-Woverflow]
> It's not real clear to me that it's worth complicating the code to
> avoid a harmless compiler warning on an 11-year-old operating system
> with minimal real-world usage. On the other hand, if you really feel
> motivated to do something about it, I'm not here to argue.
Basically, yesterday's discussion motivated me to try to clean up some
of the stray buildfarm warnings I've been ignoring for a long time.
I agree it doesn't look like this change would have any real-world
impact. But we do set some value on warning-free builds, if only to
save ourselves having to remember "this warning is harmless".
> My one
> suggestion is that if you do add some strange incantation here along
> the lines you propose, you should at least add a comment explaining
> that it was done to suppress a warning on AIX 7.1.
But of course.
regards, tom lane
