On Wed, Feb 16, 2022 at 5:03 AM Tomas Vondra <tomas.von...@enterprisedb.com> wrote: > > Hi, > > Here's an updated version of the patch, rebased to current master. Parts > 0002 and 0003 include various improvements based on review by me and > another one by Peter Smith [1]. > > Part 0003 reworks and significantly extends the TAP test, to exercise > various cases related to changes of replica identity etc. discussed in > this thread. Some of the tests however still fail, because the behavior > was not updated - I'll work on that once we agree what the expected > behavior is. > > 1) partitioning with pubviaroot=true > > The main set of failures is related to partitions with different replica > identities and (pubviaroot=true), some of which may be mismatching the > column list. There are multiple such test cases, depending on how the > inconsistency is introduced - it may be there from the beginning, the > column filter may be modified after adding the partitioned table to the > publication, etc. > > I think the expected behavior is to prohibit such cases from happening, > by cross-checking the column filter when adding the partitioned table to > publication, attaching a partition or changing a column filter. >
I feel it is better to follow the way described by Peter E. here [1] to handle these cases. The row filter patch is also using the same scheme as that is what we are doing now for Updates/Deletes and it would be really challenging and much more effort/code to deal with everything at DDL time. I have tried to explain some of that in my emails [2][3]. [1] - https://www.postgresql.org/message-id/ca91dc91-80ba-e954-213e-b4170a6160f5%40enterprisedb.com [2] - https://www.postgresql.org/message-id/CAA4eK1%2Bm45Xyzx7AUY9TyFnB6CZ7_%2B_uooPb7WHSpp7UE%3DYmKg%40mail.gmail.com [3] - https://www.postgresql.org/message-id/CAA4eK1%2B1DMkCip9SB3B0_u0Q6fGf-D3vgqQodkLfur0qkL482g%40mail.gmail.com -- With Regards, Amit Kapila.