Hi, On 2022-02-16 18:51:37 -0500, Tom Lane wrote: > This seems workable, and you'll notice it fixes the duplicated text > in the test case Andres was worried about.
Cool. I find it mildly scary that we didn't have any other tests verifying the libpq side of connection termination. Seems like we we maybe should add a few more? Some simple cases we can do via isolationtester. But some others would probably require a C test program to be robust... > + /* Also, do nothing if the argument is OOM_result */ > + if (res == unconstify(PGresult *, &OOM_result)) > + return; Wouldn't it make more sense to make res const, rather than unconstifying &OOM_result? Greetings, Andres Freund
