Michael Paquier <mich...@paquier.xyz> writes: > On Wed, Feb 16, 2022 at 01:25:09PM +0900, Kasahara Tatsuhito wrote: >> Remove all references to tuplestore_donestoring() except for the header. > > Looks fine, thanks. This has no impact on Melanie's patch posted on > [1], so applied after tweaking the comment in tuplestore.h.
Would it be possible to make that macro only defined when building extensions, but not when building Postgres itself? For example, Perl has a PERL_CORE macro that's only defined when building Perl itself, but not when building CPAN modules, and backwards-compatibility macros and functions are guarded by `#ifndef PERL_CORE`. - ilmari