On Fri, Feb 25, 2022 at 4:41 PM Magnus Hagander <mag...@hagander.net> wrote: > > On Fri, Feb 25, 2022 at 4:40 PM Julien Rouhaud <rjuju...@gmail.com> wrote: > > > > On Fri, Feb 25, 2022 at 04:19:27PM +0100, Magnus Hagander wrote: > > > > > > So just to be clear, you're basically thinking: > > > > > > jit_count = count of entries where jit_functions>0 > > > jit_functions = <same as now> > > > jit_optimizatinos = count of entries where time spent on > > > jit_optimizations > 0 > > > > > > etc? > > > > Yes exactly, so 3 new fields on top of the one you already added. > > > > > So we count the times with min/max like other times for the total one, > > > but instead add a counter for each of the details? > > > > I don't understand this one. Did you mean we *don't* count times with > > min/max? > > If that's the case then yes :) > > Hmm. Yeah, that was a bit unclear. I mean we track total time with > min/max, and detailed time not at all. For details, we only track > count, not time.
Per some off-list discussion with Julien, we have clearly been talking in slightly different terms. So let's summarize the options into what theÿ́d actually be: Option 0: what is int he patch now Option 1: jit_count - number of executions using jit total_jit_time - for sum of functions+inlining+optimization+emission time min_jit_time - for sum of functions+inlining+optimization+emission time max_jit_time - for sum of functions+inlining+optimization+emission time mean_jit_time - for sum of functions+inlining+optimization+emission time stddev_jit_time - for sum of functions+inlining+optimization+emission time jit_functions - number of functions jit_inlining_count - number of executions where inlining happened jit_optimization_count - number of executions where optimization happened jit_emission_count - number of executions where emission happened Option 2: jit_count jit_functions jit_generation_time jit_inlining_count jit_inlining_time jit_optimization_count jit_optimization_time jit_emission_count jit_emission_time (We can bikeshed on the exact names of the fields once we have decided which option is preferred) -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/