On Wed, Mar 2, 2022 at 7:47 AM Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > > At Sat, 19 Feb 2022 09:31:33 +0530, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote in > > The changes looks good. thanks.! > > Thanks! > > Some recent core change changed WAL insertion speed during the TAP > test and revealed one forgotton case of EndOfWAL. When a record > header flows into the next page, XLogReadRecord does separate check > from ValidXLogRecordHeader by itself. >
The new changes made in the patch look good. Thanks to the recent changes to speed WAL insertion that have helped us catch this bug. One small comment: record = (XLogRecord *) (state->readBuf + RecPtr % XLOG_BLCKSZ); - total_len = record->xl_tot_len; Do you think we need to change the position of the comments written for above code that says: /* * Read the record length. * ... ... -- With Regards, Ashutosh Sharma.