On Thu, 03 Mar 2022 at 12:10, Japin Li <[email protected]> wrote:
> On Thu, 03 Mar 2022 at 11:25, David G. Johnston <[email protected]>
> wrote:
>> I would suggest a wording more like:
>>
>> "A precondition for using minimal WAL is to disable WAL archiving and
>> streaming replication by setting max_wal_senders to 0, and archive_mode to
>> off."
>>
>> While accurate, the phrase "you must set" just doesn't feel right to me. I
>> also don't like how the proposed sentence (either one) is added separately
>> as opposed to being included in the immediately preceding paragraph. While
>> this limited patch is probably sufficient I would suggest trying to work
>> out a slightly larger patch the improves the wording on the entire existing
>> paragraph while incorporating the reference to max_wal_senders.
>>
>
> Thanks for your review. Modified as your suggestion.
>
>> Note, we seem to be missing the documentation of the default setting for
>> archive_mode.
>>
>
> Add the default value for archive_mode.
>
>> In addition, max_wal_senders could also be changed, adding a sentence like:
>>
>> "If setting max_wal_senders to 0 consider also reducing the amount of WAL
>> produced by changing wal_level to minimal."
>>
>
> Modified.
Attach v3 patch to fix missing close varname tag.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 7ed8c82a9d..bc7ba1e120 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -2775,6 +2775,10 @@ include_dir 'conf.d'
<literal>minimal</literal> makes any base backups taken before
unavailable for archive recovery and standby server, which may
lead to data loss.
+ A precondition for using minimal WAL is to disable WAL archiving and
+ streaming replication by setting <xref linkend="guc-max-wal-senders"/>
+ to <literal>0</literal>, and <varname>archive_mode</varname>
+ to <literal>off</literal>.
</para>
<para>
In <literal>logical</literal> level, the same information is logged as
@@ -3535,6 +3539,7 @@ include_dir 'conf.d'
mode. In <literal>always</literal> mode, all files restored from the archive
or streamed with streaming replication will be archived (again). See
<xref linkend="continuous-archiving-in-standby"/> for details.
+ The default value is <literal>off</literal>.
</para>
<para>
This parameter can only be set at server start.
@@ -4096,7 +4101,9 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows
reconnect. This parameter can only be set at server start. Also,
<varname>wal_level</varname> must be set to
<literal>replica</literal> or higher to allow connections from standby
- servers.
+ servers. If setting <varname>max_wal_senders</varname> to
+ <literal>0</literal> consider also reducing the amount of WAL produced
+ by changing <varname>wal_level</varname> to <literal>minimal</literal>.
</para>
<para>
