On Mon, Mar 7, 2022 at 5:51 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Mar 7, 2022 at 5:01 PM Ashutosh Bapat > <ashutosh.bapat....@gmail.com> wrote: > > > > Hi Vignesh, > > I agree with Peter's comment that the changes to > > FilterRemoteOriginData() should be part of FilterByOrigin() > > > > Further, I wonder why "onlylocal_data" is a replication slot's > > property. A replication slot tracks the progress of replication and it > > may be used by different receivers with different options. I could > > start one receiver which wants only local data, say using > > "pg_logical_slot_get_changes" and later start another receiver which > > fetches all the data starting from where the first receiver left. This > > option prevents such flexibility. > > > > As discussed earlier in the thread, local_only can be property of > > publication or subscription, depending upon the use case, but I can't > > see any reason that it should be tied to a replication slot. > > > > I thought it should be similar to 'streaming' option of subscription > but may be Vignesh has some other reason which makes it different.
Yes, this can be removed from the replication slot. It is my mistake that I have made while making the code similar to two-phase, I'm working on making the changes for this. I will fix and post an updated version for this. Regards, Vignesh
