On Mon, Mar 21, 2022 at 7:09 AM Euler Taveira <eu...@eulerto.com> wrote: > > src/test/subscription/t/029_disable_on_error.pl | 94 ---------- > src/test/subscription/t/029_on_error.pl | 183 +++++++++++++++++++ > > It seems you are removing a test for 705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33. >
We have covered the same test in the new test file. See "CREATE SUBSCRIPTION sub CONNECTION '$publisher_connstr' PUBLICATION pub WITH (disable_on_error = true, ...". This will test the cases we were earlier testing via 'disable_on_error'. > I should also name 029_on_error.pl to something else such as 030_skip_lsn.pl > or > a generic name 030_skip_option.pl. > The reason to keep the name 'on_error' is that it has tests for both 'disable_on_error' option and 'skip_lsn'. The other option could be 'on_error_action' or something like that. Now, does this make sense to you? -- With Regards, Amit Kapila.
