On Fri, Mar 25, 2022 at 2:19 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Mar 25, 2022 at 2:23 PM wangw.f...@fujitsu.com > <wangw.f...@fujitsu.com> wrote: > > > > On Thur, Mar 24, 2022 at 6:32 PM Amit Kapila <amit.kapil...@gmail.com> > wrote: > > > > > Thanks for your kindly update. > > > > > It seems by mistake you have removed the changes from > pgoutput_message > > > and pgoutput_truncate functions. I have added those back. > > > Additionally, I made a few other changes: (a) moved the function > > > UpdateProgress to pgoutput.c as it is not used outside it, (b) change > > > the new parameter in plugin API from 'send_keep_alive' to 'last_write' > > > to make it look similar to WalSndPrepareWrite and WalSndWriteData, (c) > > > made a number of changes in WalSndUpdateProgress API, it is better to > > > move keep-alive code after lag track code because we do process > > > replies at that time and there it will compute the lag; (d) > > > changed/added comments in the code. > > > > > > Do let me know what you think of the attached? > > It looks good to me. Just rebase it because the change in header(75b1521). > > I tested it and the result looks good to me. > > Since commit 75b1521 added decoding of sequence to logical > replication, the patch needs to have pgoutput_sequence() call > update_progress(). Thanks for your comments.
Yes, you are right. Add missing handling of pgoutput_sequence. Attach the new patch. Regards, Wang wei
v7-0001-Fix-the-logical-replication-timeout-during-large-.patch
Description: v7-0001-Fix-the-logical-replication-timeout-during-large-.patch
