On Fri, Mar 25, 2022 at 7:41 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Thu, Mar 24, 2022 at 12:12 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > Thanks, I have gone through your changes in comments and docs and those > > LGTM. > > It looks like this patch will need to be updated for Alvaro's commit > 49d9cfc68bf4e0d32a948fe72d5a0ef7f464944e. The newly added test > 029_replay_tsp_drops.pl fails with this patch applied. The standby log > shows: > > 2022-03-25 10:00:10.022 EDT [38209] LOG: entering standby mode > 2022-03-25 10:00:10.024 EDT [38209] LOG: redo starts at 0/3000028 > 2022-03-25 10:00:10.062 EDT [38209] FATAL: could not create directory > "pg_tblspc/16385/PG_15_202203241/16390": No such file or directory > 2022-03-25 10:00:10.062 EDT [38209] CONTEXT: WAL redo at 0/43EBD88 > for Database/CREATE_WAL_LOG: create dir 16385/16390 > > On a quick look, I'm guessing that XLOG_DBASE_CREATE_WAL_LOG will need > to mirror some of the logic that was added to the replay code for the > existing strategy, but I haven't figured out the details. >
Yeah, I think I got it, for XLOG_DBASE_CREATE_WAL_LOG now we will have to handle the missing parent directory case, like Alvaro handled for the XLOG_DBASE_CREATE(_FILE_COPY) case. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
