Hi, On 2022-03-26 17:41:53 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > I wonder if we ought to make PG_GETARG_DATUM(n) assert that > > !PG_ARGISNULL(n)? > > That'd perhaps make it easier to catch some of these... > > Don't see the point; such cases will crash just fine without any > assert. The problem is lack of test coverage ...
Not reliably. Byval types typically won't crash, just do something bogus. As e.g. in the case of pg_stat_get_subscription_stats(NULL) I found to also be wrong upthread. Greetings, Andres Freund
