amul sul wrote: > On Sat, Apr 7, 2018 at 9:08 AM, Andres Freund <and...@anarazel.de> wrote:
> >> +test: partition-key-update-1 > >> +test: partition-key-update-2 > >> +test: partition-key-update-3 > > > > Can you give these more descriptive names please (or further combine them)? > > As I explained above further combining might not the good option and about > the descriptive names I have following suggestions but I am afraid of > the length of > test case name: > > +test: concurrent-partition-key-update.out > > This test does the serialization failure check. > > +test: concurrent-partition-key-update-and-insert-conflict-do-nothing-1 > +test: concurrent-partition-key-update-and-insert-conflict-do-nothing-2 Yikes. I'd rather have the original name, and each test's purpose stated in a comment in the spec file itself. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
