On Tue, Mar 29, 2022 at 9:25 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Mar 28, 2022 at 3:08 PM Robert Haas <robertmh...@gmail.com> wrote: > > smgrcreate() as we would for most WAL records or whether it should be > > adopting the new system introduced by > > 49d9cfc68bf4e0d32a948fe72d5a0ef7f464944e. I wrote about this concern > > over here: > > > > http://postgr.es/m/CA+TgmoYcUPL+WOJL2ZzhH=zmrhj0iOQ=icfm0suyqbbqzea...@mail.gmail.com > > > > But apart from that question your adaptations here look reasonable to me. > > That commit having been reverted, I committed v6 instead. Let's see > what breaks... >
There was a duplicate error check for the invalid createdb strategy option in the test case, although it would not create any issue but it is duplicate so I have fixed it in the attached patch. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
diff --git a/src/bin/scripts/t/020_createdb.pl b/src/bin/scripts/t/020_createdb.pl index b81f06a..18f6e31 100644 --- a/src/bin/scripts/t/020_createdb.pl +++ b/src/bin/scripts/t/020_createdb.pl @@ -109,7 +109,7 @@ $node->command_checks_all( 1, [qr/^$/], [ - qr/^createdb: error: database creation failed: ERROR: invalid create database strategy|^createdb: error: database creation failed: ERROR: invalid create database strategy foo/s + qr/^createdb: error: database creation failed: ERROR: invalid create database strategy foo/s ], 'createdb with incorrect --strategy');
