On Thu, Mar 31, 2022 at 03:38:39PM +0100, Devrim Gündüz wrote: > On Thu, 2022-03-31 at 10:26 -0400, Tom Lane wrote: > > Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <dev...@gunduz.org> writes: > > > Latest snapshot tarball fails to build on SLES 12.5, which uses GCC > > > 4.8-8. Build log is attached. > > > > Hmm, what version of libzstd is present? > > 1.3.3
That's due to commit e9537321a74a2b062c8f7a452314b4570913f780. Possible responses look like: - Use 0 which also means "default" (need to verify that works across versions); - Or #ifndef ZSTD_CLEVEL_DEFAULT #define ZSTD_CLEVEL_DEFAULT 3; - Add a test for a minimum zstd version v1.3.7. This may be a good idea for v15 in any case, since we're using a few different APIs (at least ZSTD_compress and ZSTD_compressStream2 and execve(zstd)). I dug up this history: commit b2632bcf6cf7b9b96e0ac99beea079df4d1eaec5 Merge: 170f948e 869e2718 Author: Yann Collet <cyan4...@users.noreply.github.com> Date: Tue Jun 12 12:09:01 2018 -0700 Merge pull request #1174 from duc0/document_default_level Expose ZSTD_CLEVEL_DEFAULT and update documentation commit e34c000e44444b9f8bd62e5af0a355ee186eb21f Author: Duc Ngo <d...@fb.com> Date: Fri Jun 8 11:29:51 2018 -0700 Expose ZSTD_CLEVEL_DEFAULT and update documentation commit 6d4fef36de21908e333b2a1fde8ded0a7f086ae1 Author: Yann Collet <c...@fb.com> Date: Wed May 17 18:36:15 2017 -0700 Added ZSTD_compress_generic() Used in fileio.c (zstd cli). Need to set macro ZSTD_NEWAPI to trigger it. commit 236d94fa9a4ff8723922971274a119c6084d5dbc Author: Yann Collet <yann.collet...@gmail.com> Date: Wed May 18 12:06:33 2016 +0200 reverted default compression level to 1