Hello, David. Thanks for your review!
> As a specific recommendation here - submit patches with a complete commit > message. > Tweak it for each new version so that any prior discussion that informed the > general design of > the patch is reflected in the commit message. Yes, agreed. Applied to my other patch (1). > In terms of having room for bugs this description seems like a lot of logic > to have to get correct. Yes, it is the scary part. But it is contained in single is_index_lp_dead_maybe_allowed function for now. > Could we just do this first pass as: > Enable recovery mode LP_DEAD hint bit updates after the first streamed > CHECKPOINT record comes over from the primary. > ? Not sure, but yes, it is better to split the patch into more detailed commits. Thanks, Michail. [1]: https://www.postgresql.org/message-id/flat/CANtu0ogzo4MsR7My9%2BNhu3to5%3Dy7G9zSzUbxfWYOn9W5FfHjTA%40mail.gmail.com#341a3c3b033f69b260120b3173a66382
