On Fri, Apr 1, 2022 at 12:45 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Amit Langote <amitlangot...@gmail.com> writes: > > On Fri, Apr 1, 2022 at 10:32 AM David Rowley <dgrowle...@gmail.com> wrote: > >> 1. You've changed the signature of various functions by adding > >> ExecLockRelsInfo *execlockrelsinfo. I'm wondering why you didn't just > >> put the ExecLockRelsInfo as a new field in PlannedStmt? > > > I'm worried about that churn myself and did consider this idea, though > > I couldn't shake the feeling that it's maybe wrong to put something in > > PlannedStmt that the planner itself doesn't produce. > > PlannedStmt is part of the plan tree, which MUST be read-only to > the executor. This is not negotiable. However, there's other > places that this data could be put, such as QueryDesc. > Or for that matter, couldn't the data structure be created by > the planner? (It looks like David is proposing exactly that > further down.)
The data structure in question is for storing the results of performing initial partition pruning on a generic plan, which the proposes to do in plancache.c -- inside the body of AcquireExecutorLocks()'s loop over PlannedStmts -- so, it's hard to see it as a product of the planner. :-( -- Amit Langote EDB: http://www.enterprisedb.com