On 2022-04-06 16:44, Mark Wong wrote:
I think I've applied all of these suggestions and attached a new patch.
That looks good to me, though I wonder about the pfree(source). In the simplest case of a PL that uses no advance compilation or augmentation step, the Code Execution block might naturally refer to source, so perhaps the example boilerplate shouldn't include a pfree that needs to be removed in that case. In fact, I wonder about the need for any retail pfree()s here. Those added in this patch are the only ones in plsample.c. They are small allocations, and maybe it would both streamline the example to leave out the pfree calls, and be an illustration of best practice in letting the memory context machinery handle all the deallocation at once, where there isn't a special need to free something, like an especially large allocation, at retail. Regards, -Chap
