When reviewing the patch in "Frontend error logging style" [0] I noticed that some messages could do with a little bit of touching up. The original review was posted and responded to in that thread, but to keep goalposts in place it was put off until that patch had landed. To avoid this getting buried in that thread I decided to start a new one with the findings from there. To make reviewing easier I split the patch around the sorts of changes proposed.
0001: Makes sure that database and file names are printed quoted. This patch has hunks in contrib and backend as well. 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error with a lowercase letter without punctuation. 0003: Extend a few messages with more information to be more consistent with other messages (and more helpful). 0004: Add pg_log_error() calls on all calls to close in pg_basebackup. Nearly all had already, and while errors here are likely to be rare, when they do happen something is really wrong and every bit of information can help debugging. 0005: Put keywords as parameters in a few pg_dump error messages, to make their translations reuseable. -- Daniel Gustafsson https://vmware.com/ [0] https://postgr.es/m/1363732.1636496...@sss.pgh.pa.us
0005-Parameterize-values-to-lessen-translation-burden.patch
Description: Binary data
0004-Add-errorhandling-on-file-close.patch
Description: Binary data
0003-Add-additional-information-to-be-more-helpful.patch
Description: Binary data
0002-pg_log_error-and-pg_log_error_detail-capitalization-.patch
Description: Binary data
0001-Ensure-file-and-database-names-are-quoted.patch
Description: Binary data