On Sat, Apr 23, 2022 at 5:59 PM Noah Misch <n...@leadboat.com> wrote: > This (commit 77bae39) did not change function parameter counts, and > TUPLESORT_RANDOMACCESS generally has same the same numeric value as "true". I > get no warning if I pass "true" for the "sortopt" flags parameter. Hence, I > suspect this did not break the API. Should we be happy about that? I'm fine > with it.
If I happened to believe that this issue (or one like it) might have real negative consequences, and that those consequences could easily be avoided (by making the API break impossible to overlook), then I would object -- why even take a small chance? Fortunately I don't believe that we're even taking a small chance here, all things considered. And so I agree; this issue isn't a concern. -- Peter Geoghegan
