On Fri, May 20, 2022 at 10:19 AM Peter Smith <smithpb2...@gmail.com> wrote: > > FYI, although the v6-0002 patch applied cleanly, I found that the SGML > was malformed and so the pg docs build fails. > > ~~~ > e.g. > > [postgres@CentOS7-x64 sgml]$ make STYLE=website html > { \ > echo "<!ENTITY version \"15beta1\">"; \ > echo "<!ENTITY majorversion \"15\">"; \ > } > version.sgml > '/usr/bin/perl' ./mk_feature_tables.pl YES > ../../../src/backend/catalog/sql_feature_packages.txt > ../../../src/backend/catalog/sql_features.txt > > features-supported.sgml > '/usr/bin/perl' ./mk_feature_tables.pl NO > ../../../src/backend/catalog/sql_feature_packages.txt > ../../../src/backend/catalog/sql_features.txt > > features-unsupported.sgml > '/usr/bin/perl' ./generate-errcodes-table.pl > ../../../src/backend/utils/errcodes.txt > errcodes-table.sgml > '/usr/bin/perl' ./generate-keywords-table.pl . > keywords-table.sgml > /usr/bin/xmllint --path . --noout --valid postgres.sgml > ref/create_publication.sgml:171: parser error : Opening and ending tag > mismatch: varlistentry line 166 and listitem > </listitem> > ^ > ref/create_publication.sgml:172: parser error : Opening and ending tag > mismatch: variablelist line 60 and varlistentry > </varlistentry> > ^ > ref/create_publication.sgml:226: parser error : Opening and ending tag > mismatch: refsect1 line 57 and variablelist > </variablelist> > ^ > ... > > I will work around it locally, but for future patches please check the > SGML builds ok before posting.
FYI, I rewrote the bad SGML fragment like this: <varlistentry> <term><literal>EXCEPT TABLE</literal></term> <listitem> <para> This clause specifies a list of tables to exclude from the publication. It can only be used with <literal>FOR ALL TABLES</literal>. </para> </listitem> </varlistentry> ------ Kind Regards, Peter Smith. Fujitsu Australia