On Friday, May 27, 2022 1:54 PM Justin Pryzby <pry...@telsasoft.com> wrote: > > On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote: > > On Tue, May 24, 2022 at 11:03 AM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > > > > > On Friday, May 20, 2022 11:06 AM Amit Kapila <amit.kapil...@gmail.com> > wrote: > > > > > > Thanks for pointing it out. Here is the new version patch which add this > version check. > > > > I have added/edited a few comments and ran pgindent. The attached > > looks good to me. I'll push this early next week unless there are more > > comments/suggestions. > > A minor doc review. > Note that I also sent some doc comments at > 20220519120724.go19...@telsasoft.com. > > + lists among publications in which case <command>ALTER > PUBLICATION</command> > + command will be successful but later the WalSender in publisher > + or the > > COMMA in which > > remove "command" ? > > s/in publisher/on the publisher/ > > + Subscription having several publications in which the same table has been > + published with different column lists is not supported. > > Either "Subscriptions having .. are not supported"; or, "A subscription > having .. > is not supported".
Thanks for the comments. Here is the new version patch set which fixes these. Best regards, Hou zj
0001-language-fixes-on-HEAD-from-Justin.patch
Description: 0001-language-fixes-on-HEAD-from-Justin.patch
v6-0001-Prohibit-combining-publications-with-different-co.patch
Description: v6-0001-Prohibit-combining-publications-with-different-co.patch
