On Mon, Jun 20, 2022 at 3:46 PM shiy.f...@fujitsu.com <shiy.f...@fujitsu.com> wrote: > On Mon, Jun 20, 2022 1:33 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > One minor comment: > > + /* > > + * If it is a partitioned table, we don't check it, we will check its > > + * partition later. > > + */ > > > > Can we change the above comment to: "For partitioned tables, we only > > need to care if the target partition is updatable (aka has PK or RI > > defined for it)."? > > > Thanks for your comment. Modified in the attached patches.
How about: ...target "leaf" partition is updatable Regarding the commit message's top line, which is this: Fix partition table's RI checking on the subscriber. I think it should spell out REPLICA IDENTITY explicitly to avoid the commit being confused to have to do with "Referential Integrity checking". -- Thanks, Amit Langote EDB: http://www.enterprisedb.com