On 2018/04/13 3:10, Alvaro Herrera wrote: > Alvaro Herrera wrote: > >> I'm dealing with this now -- will push shortly. The sane thing to do is >> backpatch my previous memcxt fixes, since your patch introduces a >> problem that we discussed with that other patch, namely that you would >> leak the whole memory context if there is a problem while running the >> function. I also noticed here that copy_partition_key is doing memcpy() >> on the fmgr_info, which is bogus -- it should be using fmgr_info_copy. >> Rather than patching that one piece it seems better to replace it >> wholesale, since I bet this won't be the last time we'll hear about this >> routine, and I would prefer not to deal with differently broken code in >> the older branch. > > Pushed.
Thanks for fixing that. Regards, Amit
