On Fri, Apr 13, 2018 at 10:45 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > As long as btree only has one no-data tuple per page, I think we are good, > because this calculation does not account for page special space. We might > be underestimating how many tuples can fit by one MAXALIGN quantum, but > the special space takes up at least one MAXALIGN quantum, so it's safe. > > Twouldn't be a bad idea to document this reasoning, though.
Thanks for taking care of this. > Also, my first reaction on looking at this code was "who added > MinIndexTupleSize and then didn't replace the equivalent subexpression > of MaxIndexTuplesPerPage with MinIndexTupleSize?". I had the same reaction. -- Peter Geoghegan
