On Fri, Jul 29, 2022 at 3:29 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2022-Jul-29, Peter Smith wrote: > > > On Fri, Jul 29, 2022 at 7:36 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> > > wrote: > > > > > > I don't object to doing this, but I think these two functions should > > > stay together nonetheless. > > > > If you believe there is still a problem after applying the patch > > please explicitly name what function(s) you think should be moved. > > Well, I checked the commit and the functions I was talking about look OK > now. However, looking again, pg_relation_is_publishable is in the wrong > place (should be right below is_publishable_relaton), and I wonder why > aren't get_publication_oid and get_publication_name in lsyscache.c. >
Right, both these suggestions make sense to me. Similarly, I think functions get_subscription_name and get_subscription_oid should also be moved to lsyscache.c. -- With Regards, Amit Kapila.
