Oversight in slab.c SlabContextCreate(), initial memory allocation size is not populated to context->mem_allocated

[Reid Thompson]

Hi,

Both aset.c and generation.c populate mem_allocated in
AllocSetContextCreateInternal(), GenerationContextCreate()
respectively.
aset.c                                                                
    /* Finally, do the type-independent part of context creation */   
    MemoryContextCreate((MemoryContext) set,                          
                        T_AllocSetContext,                            
                        &AllocSetMethods,                             
                        parent,                                       
                        name);                                        
                                                                                
                                                    
    ((MemoryContext) set)->mem_allocated = firstBlockSize;            
                                                                                
                                                    
    return (MemoryContext) set;                                       
}                                                                     
                                                                                
                                                    
generation.c                                                          
    /* Finally, do the type-independent part of context creation */   
    MemoryContextCreate((MemoryContext) set,                          
                        T_GenerationContext,                          
                        &GenerationMethods,                           
                        parent,                                       
                        name);                                        
                                                                                
                                                    
    ((MemoryContext) set)->mem_allocated = firstBlockSize;            
                                                                                
                                                    
    return (MemoryContext) set;                                       
}   

slab.c
does not in SlabContextCreate(). Is this intentional, it seems to be an
oversight to me.

    /* Finally, do the type-independent part of context creation */   
    MemoryContextCreate((MemoryContext) slab,                         
                        T_SlabContext,                                
                        &SlabMethods,                                 
                        parent,                                       
                        name);                                        
                                                                                
                                                    
    return (MemoryContext) slab;                                      
}                      
-- 
Reid Thompson
Senior Software Engineer
Crunchy Data, Inc.

reid.thomp...@crunchydata.com
www.crunchydata.com