On Fri, Jul 29, 2022 at 2:35 PM Robert Haas <robertmh...@gmail.com> wrote: > But what exactly is this test case testing? I've previously complained > about buildfarm outputs not being as labelled as well as they need to > be in order to be easily understood by, well, me anyway. It'd sure > help if the commands that led up to this problem were included in the > output. I downloaded latest-client.tgz from the build farm server and > am looking at TestUpgradeXversion.pm, but there's no mention of > -amcheck-1.log in there, just -analyse.log, -copy.log, and following. > So I suppose this is running some different code or special > configuration...
I was able to reproduce the problem by running 'make installcheck' against a 9.4 instance and then doing a pg_upgrade to 16devel (which took many tries because it told me about many different kinds of things that it didn't like one at a time; I just dropped objects from the regression DB until it worked). The dump output looks like this: -- For binary upgrade, set pg_largeobject relfrozenxid and relminmxid UPDATE pg_catalog.pg_class SET relfrozenxid = '0', relminmxid = '0' WHERE oid = 2683; UPDATE pg_catalog.pg_class SET relfrozenxid = '990', relminmxid = '1' WHERE oid = 2613; -- For binary upgrade, preserve pg_largeobject and index relfilenodes SELECT pg_catalog.binary_upgrade_set_next_index_relfilenode('12364'::pg_catalog.oid); SELECT pg_catalog.binary_upgrade_set_next_heap_relfilenode('12362'::pg_catalog.oid); TRUNCATE pg_catalog.pg_largeobject; However, the catalogs show the relfilenode being correct, and the relfrozenxid set to a larger value. I suspect the problem here is that this needs to be done in the other order, with the TRUNCATE first and the update to the pg_class columns afterward. I think I better look into improving the TAP tests for this, too. -- Robert Haas EDB: http://www.enterprisedb.com