Kyotaro Horiguchi <horikyota....@gmail.com> writes: > Please find the attached. I added some regression tests for both > pg_read_file() and pg_read_binary_file().
Yeah, I definitely find this way cleaner even if it's a bit more verbose. I think that the PG_RETURN_NULL code paths are not reachable in the wrappers that don't have missing_ok. I concur with your decision to write them all the same, though. Pushed after some fooling with the docs and test cases. (Notably, I do not think we can assume that pg_hba.conf exists in $PGDATA; some installations keep it elsewhere. I used postgresql.auto.conf instead.) regards, tom lane