Hi, On 2022-08-23 19:50:00 -0400, Tom Lane wrote: > Robert Haas <robertmh...@gmail.com> writes: > > On Tue, Aug 23, 2022 at 7:24 PM Andres Freund <and...@anarazel.de> wrote: > >> Just to make sure I understand - you're just trying to get rid of the > >> #define > >> frontends, not the -DFRONTENDs passed in from the Makefile? Because afaics > >> we > >> still need those, correct? > > > Oh, yeah, this only fixes the #define ones. But maybe fixing the other > > ones with a similar approach would be possible? > > > I really don't see why we should tolerate having #define FRONTEND in > > more than once place. > > src/port and src/common really need to do it like that (ie pass in > the -D switch) so that the identical source file can be built > both ways. Maybe we could get rid of -DFRONTEND in other places, > like pg_rewind and pg_waldump.
We could, if we make xlogreader.c and the rmgrdesc routines built as part of src/common. I don't really see how otherwise. Greetings, Andres Freund
