On Thu, Jul 07, 2022 at 01:56:39PM +0900, Michael Paquier wrote: > On Thu, Jul 07, 2022 at 09:11:57AM +0900, Michael Paquier wrote: > > Okay, thanks for confirming. I think that I'll give it a try today > > then, my schedule would fit nicely with the buildfarm monitoring. > > And I have applied that, after noticing that the MinGW was complaining > because _WIN32_WINNT was not getting set like previously and removing > _WIN32_WINNT as there is no need for it anymore. The CI has reported > green for all my tests, so I am rather confident to not have messed up > something. Now, let's see what the buildfarm members tell. This > should take a couple of hours..
If I'm not wrong, there's some lingering comments which could be removed since 495ed0ef2. src/bin/pg_ctl/pg_ctl.c: * on NT4. That way, we don't break on NT4. src/bin/pg_ctl/pg_ctl.c: * On NT4, or any other system not containing the required functions, will src/bin/pg_ctl/pg_ctl.c: * NT4 doesn't have CreateRestrictedToken, so just call ordinary src/port/dirmod.c: * Win32 (NT4 and newer). src/backend/port/win32/socket.c: /* No error, zero bytes (win2000+) or error+WSAEWOULDBLOCK (<=nt4) */ -- Justin