Hi, On 2022-08-28 10:09:53 -0400, Tom Lane wrote: > Michael Paquier <[email protected]> writes: > > True enough. I have applied the patch to re-enable that on HEAD. > > Let's now see what happens in the next couple of days. Popcorn is > > ready here. > > Hmm: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2022-08-28%2010%3A30%3A29 > > Maybe that's just unrelated noise, but it sure looks weird: after > passing the core regression tests in "make check", it failed in > pg_upgrade's run with > > diff -w -U3 > H:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/xml.out > H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_upgrade/tmp_check/results/xml.out > --- H:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/xml.out > Wed May 18 18:30:12 2022 > +++ > H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_upgrade/tmp_check/results/xml.out > Sun Aug 28 06:55:14 2022 > @@ -1557,7 +1557,7 @@ > \\x > SELECT * FROM XMLTABLE('*' PASSING '<e>pre<!--c1--><?pi > arg?><![CDATA[&ent1]]><n2>&deep</n2>post</e>' COLUMNS x xml PATH > 'node()', y xml PATH '/'); > -[ RECORD 1 ]----------------------------------------------------------- > -x | pre<!--c1--><?pi arg?><![CDATA[&ent1]]><n2>&deep</n2>post > +x | pre<?pi arg?><![CDATA[&ent1]]><!--c1--><n2>&deep</n2>post > y | <e>pre<!--c1--><?pi arg?><![CDATA[&ent1]]><n2>&deep</n2>post</e>+ > |
Pretty weird, agreed. But hard to see how it could be caused by the randomization change, except that perhaps it could highlight a preexisting bug? Greetings, Andres Freund
