On 29.08.22 11:38, Anton Voloshin wrote:
I propose making them more consistent. Would the following guidelines be acceptable?
I usually try to follow the guidelines in <https://www.gnu.org/prep/standards/html_node/Comments.html>, which pretty much match what you are proposing.
And this: #else /* !_MSC_VER */ over #else /* !defined(_MSC_VER) */
Note that for _MSC_VER in particular there is some trickiness: We generally use it to tell apart different MSVC compiler versions. But it is not present with MinGW. So !_MSC_VER and !defined(_MSC_VER) have different meanings. So in this particular case, more precision in the comments might be better.